Horses! 🐎🐎🐎

[thechriskent]

Added the tiny horse pet with 11 colors for all your tiny horse needs!

Tiny Horse	Color
	Black
	Brown
	White
	Paint Brown
	Paint Black
	Paint Beige
	Socks Brown
	Socks Beige
	Socks Black
	Magical
	Warrior

Animations adapted from the beautiful Horse Sprite With Rider Asset Pack by Onfe which is free to use with attribution.

I've been using this extension for years and kept thinking it would be cool if it had some horses - then I realized you accept PRs 😀. Please let me know any adjustments you'd like or if there's anything else you need from me to get the people the horses they demand. Thank you for the amazing and fun extension!

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 15.27778% with 61 lines in your changes missing coverage. Please review.

Project coverage is 16.58%. Comparing base (3c3a51e) to head (bab8101).
Report is 7 commits behind head on master.

Files	Patch %	Lines
src/panel/pets/horse.ts	10.90%	49 Missing ⚠️
src/panel/states.ts	16.66%	10 Missing ⚠️
src/panel/pets.ts	60.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
- Coverage   16.80%   16.58%   -0.23%     
==========================================
  Files          22       23       +1     
  Lines        1166     1236      +70     
  Branches      158      167       +9     
==========================================
+ Hits          196      205       +9     
- Misses        964     1025      +61     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tonybaloney]

This is fantastic!!

Some feedback:

• Please can we have the pet type as "horse" instead of "tiny-horse". You can set the pet size to large, so they're pretty big (well not compared to an actual horse), but nothing else in the extension is tiny-xxx and they're all relatively the same size
• I'm not sure if "warrior" should be "red" as this is already a color.
• I'm not a fan of the climbing state and the jump down animation. I've never seen a horse climb vertically before. Please can we remove those.
• The horses are pretty active. The idle state is currently only designed for the left side, but it would be nice if they were idle on both sides. I grew up with horses and they spend most of the day eating grass. You could override the idle action to have longer idle times and make a flipped idle (see how the walk-right and walk-left actions work)

[tonybaloney]

Thank you for not including Pie-oh-My

[thechriskent]

Thank you for looking at this so quickly!

I've made several updates as requested:

• tiny-horse is now just horse everywhere!
  • Ironically, I only switched it to tiny-horse shortly before submitting the PR since they looked so small next to some of the other pets that they'd normally be way bigger than 😆. But makes sense to keep it consistent.
• Climbing related states are now gone.
• Added stand left and right states for grazing. Also reworked the states to slow them down overall and emphasize grazing. Let me know if this isn't quite what you were looking for.

I'd like to keep the warrior "color" if possible as warrior horses is a very fun concept to me and one I use a lot for my open-source demos. But, this is your extension, and I will respect your opinion on the matter. Just let me know if you'd still like it updated to red and I'll take care of it right away.

[tonybaloney]

I added another path into the run states as I noticed they weren't running unless you throw the ball. bab8101

In another change, I'd like to make the standing action a bit more dynamic and have each pet type be able to override it's "idleness". The cats are unrealistically active 🐱

A fun side-effect of the friendship tree is that the horses will run around in herds sometimes.

Other than that, LGTM! Thanks for the contribution

[tonybaloney]

I'd like to keep the warrior "color" if possible as warrior horses is a very fun concept to me

Sure. It's your PR 👍🏻

[tonybaloney]

Added the new colours so people can add the translations later