Relative sizes #749
Open
Relative sizes #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added launch configuration to debug with all other extensions disabled (helpful when other extensions are filling the console)
- Added PetRelativeSize enum - Added relative size choice after color when spawning a pet - Added relativeSize to state - Relative Size is applied to width/height in addition to Pet Size - Relative Size also has minor effects on speed (bigger pets go a little faster and smaller pets a little slower) - makes the gifs look better - Relative Size included in pet list
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
==========================================
+ Coverage 18.53% 18.80% +0.26%
==========================================
Files 32 32
Lines 1570 1606 +36
Branches 204 215 +11
==========================================
+ Hits 291 302 +11
- Misses 1269 1294 +25
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pets all sharing the same size but varying in the gifs themselves can create a strange experience. I'm extra aware since I caused a lot of it with the horses 😄. This has been requested here #604 and here #725.
I've added a
relativeSizeproperty to the pets that you configure when spawning a new pet. This works in conjunction with the existing size property as a multiplier.So, if you keep the default of Normal, you'll still have the monster chickens and tiny horses as expected:
But you can now adjust that by selecting different relative sizes (shown below with horse normal and chicken smaller):
Makes for some fun times!
Relative size has also been added to the state api and is included in pet-list import/export.
Hope this helps! Love this extension as always!