-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle pymysql OperationalError in worker script #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: T365136 |
siddharthvp
reviewed
May 23, 2024
siddharthvp
reviewed
May 24, 2024
siddharthvp
reviewed
May 24, 2024
siddharthvp
previously approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working fine.
An exception clause for pymysql's OperationalError has been included in the worker script. Query run (qrun) status is now updated to 'failed' and logged for operational exceptions, thus improving error handling and traceability. Bug: T365136
Bug: T365136
In an effort to facilitate debugging, the codebase now captures all exceptions rather than specifically pymysql.err.OperationalError. Alongside this, an error's traceback is being formatted and logged for additional context about the error's origin. Furthermore, the additional information pertaining to the error is now being serialized and stored into the 'extra_info' field of the 'qrun' object. Bug: T365136
Bug: T365136
siddharthvp
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(rebased)
@vivian-rook - could you deploy this one as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An exception clause for pymysql's OperationalError has been included in the worker script. Query run (qrun) status is now updated to 'failed' and logged for operational exceptions, thus improving error handling and traceability.
Bug: T365136