update deploy instructions #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharthvp
reviewed
Jun 13, 2024
| @@ -96,12 +96,13 @@ From the quarry-bastion: | |||
| `git checkout <branch>` If not deploying main | |||
| `git-crypt unlock <path to key>` | |||
| `bash deploy.sh` | |||
| `mysql -uquarry -h <trove hostname created in last step> -p < schema.sql` | |||
| In horizon point the web proxy at the new cluster. | |||
There was a problem hiding this comment.
is this required in redeployments? Does a new k8s cluster get created? I'm expecting only the Deployment k8s object to change, so not sure why the endpoint would change.
There was a problem hiding this comment.
By 'deployment' I mean to describe the procedure to deploy the project. Perhaps I should make a separate section for updating. Which is mostly just "run deploy.sh" though I haven't been testing it that way, and the ansible might need updated a little to make sure that is working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.