Enable pool_pre_ping to eliminate db connection reset errors #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sends a "SELECT 1" to the Trove db every time a db connection is retrieved from the pool. Although it adds slight latency, it is common in db pooling setups and should be worth it as it would eliminate all connection reset errors. Also set pool_size=12, increasing it from the default 5. We have 10 pods (8 web + 2 worker), so total 120 connections which is very reasonable, as Quarry is the only user of this db. Bug: T367464
dhinus
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sends a "SELECT 1" to the Trove db every time a db connection is retrieved from the pool. Although it adds slight latency, it is common in db pooling setups and should be worth it as it would eliminate all connection reset errors.
Also set pool_size=12, increasing it from the default 5. We have 10 pods (8 web + 2 worker), so total 120 connections which is very reasonable, as Quarry is the only user of this db.
Bug: T367464