Fix running query favicon becoming blue on reload

[siddharthvp]

Orange favicon = query in pending state (running or queued).
Blue favicon = query not in pending state.

Reloading the page always resulted in the default blue favicon. This has been fixed.

Bug: T362101

[dhinus]

LGTM

[vivian-rook]

I tried loading this, but it doesn't seem to work. When I reload the icon still turns to blue if the query is queued or running. I tried opening in a private tab in case I had a cached page, but I saw the same.

[siddharthvp]

It must be due to caching. The view.js file gets http-cached, so restarting the web service isn't enough to invalidate it. You might also need to do a hard reload in the browser.

[vivian-rook]

It's deployed. Let me know if it is working for you.

[siddharthvp]

Deployment doesn't seem to have worked. Although kubectl describe deploy/web shows image with pr-52 tag, contents of the repo in the pods are from pr-51. The view.js file also shows the old code.

quarry@web-559b7c494c-htjdm:/app/helm-quarry$ cat values.yaml
web:
  repository: 'quay.io/wikimedia-quarry/quarry'
  tag: pr-51 # web tag managed by github actions

worker:
  repository: 'quay.io/wikimedia-quarry/quarry'
  tag: pr-51 # worker tag managed by github actions

[vivian-rook]

Sure enough, appears to be building off of main, rather than the pr branch. I've opened T367630 to address the issue.