Restore EXPLAIN capability #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhinus
previously approved these changes
Jun 14, 2024
The explain endpoint now takes an additional db_name param, so that we can figure out the replica host to which the explain query should be sent. Bug: T205214
siddharthvp
commented
Jun 14, 2024
| ; | ||
| } | ||
| output += "\n"; | ||
| if(runtime.memberLookup((runtime.contextOrFrameLookup(context, frame, "extra")),"replag")) { | ||
| output += "\n<div class=\"alert alert-warning\">\n <h4 class=\"alert-heading\">Replication lag</h4>\n <p class=\"mb-0\">The database on which this query was executed has a <a href=\"https://replag.toolforge.org/\">synchronization delay</a> with the wiki.\n This can be caused by maintenance or incident on database, and should be resolved soon.<br>\n The modifications that was made in last <b>"; |
There was a problem hiding this comment.
These are unrelated changes that were not made in this PR. Looks like the last time someone changed query-status.html, they missed running nunjucks precompile (understandable as there's no documentation on how to update it!). Perhaps we should add a CI step to ensure compiled.js matches the original files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The explain endpoint now takes an additional db_name param, so that we can figure out the replica host to which the explain query should be sent.
Bug: T205214