sync dev to master #1

Gunasekar-K · 2025-10-23T05:42:15Z

No description provided.

…into develop

github-actions · 2025-10-23T05:42:41Z

.circleci/config.yml

+  command: |
+    sudo apt update
+    sudo apt install -y jq python3-pip
+    sudo pip3 install awscli --upgrade


[⚠️ maintainability]
Using sudo pip3 install can lead to permission issues and conflicts with system packages. Consider using a virtual environment or a tool like pipenv to manage Python dependencies.

github-actions · 2025-10-23T05:42:41Z

.circleci/config.yml

+install_deploysuite: &install_deploysuite
+  name: Installation of install_deploysuite.
+  command: |
+    git clone --branch v1.4.19 https://github.com/topcoder-platform/tc-deploy-scripts ../buildscript


[⚠️ correctness]
Cloning a specific branch from a repository without pinning to a commit hash can lead to unexpected changes if the branch is updated. Consider using a commit hash to ensure consistency.

github-actions · 2025-10-23T05:42:41Z

.circleci/config.yml

+  - setup_remote_docker
+  - run: *install_dependency
+  - run: *install_deploysuite
+  - run: docker buildx build --no-cache=true --build-arg RESET_DB_ARG=<<pipeline.parameters.reset-db>> --build-arg SEED_DATA_ARG=${DEPLOYMENT_ENVIRONMENT} -t ${APPNAME}:latest .


[💡 performance]
Using --no-cache=true in the Docker build command can significantly increase build times. Ensure this is necessary for your use case, as it forces a full rebuild every time.

github-actions · 2025-10-23T05:42:41Z

.circleci/config.yml

+        filters:
+          branches:
+            only:
+              - master


[💡 style]
The file is missing a newline at the end, which is a common convention to avoid issues with some tools and version control systems.

github-actions · 2025-10-23T05:42:44Z

.github/workflows/code_reviewer.yml

+              with:
+                  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # The GITHUB_TOKEN is there by default so you just need to keep it like it is and not necessarily need to add it as secret as it will throw an error. [More Details](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret)
+                  LAB45_API_KEY: ${{ secrets.LAB45_API_KEY }}
+                  exclude: '**/*.json, **/*.md, **/*.jpg, **/*.png, **/*.jpeg, **/*.bmp, **/*.webp' # Optional: exclude patterns separated by commas


[💡 style]
Consider adding a newline at the end of the file to adhere to POSIX standards and improve compatibility with various tools and systems.

github-actions · 2025-10-23T05:42:51Z

src/api/group/group.service.ts

 import { M2MService } from 'src/shared/modules/global/m2m.service';

-const ADMIN_GROUP_FIELDS = ['status'];
+const ADMIN_GROUP_FIELDS: string[] = [];


[⚠️ correctness]
The ADMIN_GROUP_FIELDS constant is now an empty array. If this change is intentional, ensure that any logic relying on this constant is updated accordingly. If not, consider restoring the previous values to avoid potential issues with admin field omission.

github-actions · 2025-10-23T05:42:51Z

src/api/group/group.service.ts

    }

    if (criteria.oldId) {
      prismaFilter.where.oldId = criteria.oldId;


[❗❗ correctness]
The removal of the else block that sets prismaFilter.where.oldId to not: null changes the behavior when criteria.oldId is not provided. Ensure this change is intentional and that the new behavior aligns with the expected logic.

github-actions · 2025-10-23T05:42:51Z

src/api/group/group.service.ts

      await checkGroupName(dto.name, '', tx);

      // create group
+      const createdBy = authUser.userId ? authUser.userId : '00000000';


[💡 maintainability]
The createdBy and createdAt assignments have been extracted to variables. This improves readability and maintainability by avoiding repeated expressions. Ensure that these variables are used consistently throughout the method.

github-actions · 2025-10-23T05:42:51Z

src/api/group/group.service.ts

+        createdBy,
+        createdAt,
+        // Initialize updated fields to match created fields on creation
+        updatedBy: createdBy,


[⚠️ design]
The updatedBy and updatedAt fields are initialized to match the createdBy and createdAt fields on creation. Ensure this behavior is intended and that it aligns with the business logic for newly created groups.

github-actions · 2025-10-23T05:42:56Z

src/api/subgroup/subGroup.service.ts

      await checkGroupName(dto.name, '', tx);

      // create group
+      const createdBy = authUser.userId ? authUser.userId : '00000000';


[⚠️ maintainability]
The use of a hardcoded fallback value '00000000' for createdBy might not be ideal. Consider using a more meaningful default or handling this case differently to avoid potential confusion or misuse.

github-actions · 2025-10-23T05:42:56Z

src/api/subgroup/subGroup.service.ts


      // create group
+      const createdBy = authUser.userId ? authUser.userId : '00000000';
+      const createdAt = new Date().toISOString();


[⚠️ correctness]
The createdAt value is generated using new Date().toISOString(). Ensure that the server's timezone settings are consistent and that this format aligns with the rest of your system's date handling to prevent potential discrepancies.

github-actions · 2025-10-23T05:42:56Z

src/api/subgroup/subGroup.service.ts

+        createdBy,
+        createdAt,
+        // Initialize updated fields to match created fields on creation
+        updatedBy: createdBy,


[⚠️ correctness]
Initializing updatedBy and updatedAt to the same values as createdBy and createdAt is logical for creation, but ensure that these fields are properly updated in subsequent operations to reflect actual updates.

github-actions · 2025-10-23T05:43:00Z

src/main.ts

    methods: 'GET, POST, OPTIONS, PUT, DELETE, PATCH',
+    origin: (requestOrigin, callback) => {
+      if (!requestOrigin) {
+        return callback(null, false);


[⚠️ correctness]
Returning false for a missing requestOrigin might cause issues if there are legitimate requests without an Origin header, such as server-to-server requests. Consider allowing such requests or handling them differently.

github-actions · 2025-10-23T05:43:00Z

src/main.ts

+      if (isAllowedOrigin(requestOrigin)) {
+        return callback(null, requestOrigin);
+      }
+


[💡 maintainability]
Returning false for origins not in the allow list without logging could make debugging difficult. Consider logging the rejected origin for better traceability.

github-actions · 2025-10-23T05:43:03Z

src/shared/enums/userRole.enum.ts

 */
 export enum UserRole {
-  Admin = 'Administrator',
+  Admin = 'administrator',


[❗❗ correctness]
Changing the value of Admin from 'Administrator' to 'administrator' could impact any logic that relies on case-sensitive string comparison. Ensure that all usages of this enum value are updated accordingly to prevent potential bugs.

github-actions · 2025-10-23T05:43:06Z

src/shared/modules/global/jwt.service.ts

-        ALL_SCOPE_MAPPINGS[scope].forEach((s) => expandedScopes.add(s));
+    while (queue.length > 0) {
+      const scope = queue.shift();
+      if (!scope || expandedScopes.has(scope)) {


[⚠️ performance]
The queue.shift() operation is O(n) in time complexity because it requires shifting all elements in the array. Consider using a different data structure, such as a linked list, for better performance if the queue is expected to be large.

Gunasekar-K and others added 14 commits July 29, 2025 15:57

circleci integration

97649fe

Better CORS

d73289a

Merge branch 'develop' of github.com:topcoder-platform/groups-api-v6 …

d043096

…into develop

CORS update

55bce4b

Fix administrator role name

8ef6a2c

Expose API docs

bcc497c

CORS updates

3a57300

add review buddy

a7a6694

Fix for handling new groups (PM-2277)

9993ae4

Fix adding groups as members of groups

de87c0a

README update

048d407

Remove destructive target

17f01ff

Fixes for scope checks

5919454

Return the status on GET requests

1208653

Gunasekar-K merged commit a23be38 into master Oct 23, 2025
2 checks passed

github-actions bot reviewed Oct 23, 2025

View reviewed changes

sync dev to master #1

sync dev to master #1

Uh oh!

Conversation

Gunasekar-K commented Oct 23, 2025

Uh oh!

Uh oh!

github-actions bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants