[SignedDistanceField] add module #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-tierny
requested changes
Jun 28, 2024
There was a problem hiding this comment.
Hi Mathieu,
thanks a lot for this great work.
I played quite extensively with the filter, and it works great (although I found that the FastMarchingBand was really really off, and that the Fast Marching was extremely slow!!!) But I guess that's fine. The default backend is doing a great job and looks fairly efficient.
Can you please address the few comments I posted in the code?
Thanks a lot!
|
alright, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a module to compute a signed distance field given a triangulation representing a surface.
It implements an exact backend (accelerated with a BVH data structure), the fast marching backend [Sethian, 1996] being a fast approximation and the fast marching band method, a variant of the fast marching, being faster than the latter but also being a less good approximation.