Fast persistence update #1041
Merged
Fast persistence update #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot. I'll go ahead and review (preliminary tests show no performance loss with regard to the dev branch.) |
julien-tierny
requested changes
Jul 4, 2024
There was a problem hiding this comment.
Hi Mohamed,
thanks a lot for the PR.
it looks good to me.
I have one question though (I believe a line is not necessary, thanks for double-checking), and one remark regarding comments.
I removed a number of unnecessary includes. you may want to double-check those in the future (maybe your editor is adding them automatically. if that's the case, thanks for disabling that feature in your settings)
|
it's all good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes to modify the discrete gradient calculation code by incorporating a rapid persistence update.