Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch annotations onto STS provisioned PVCs #306

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sam-mcbr
Copy link
Contributor

@sam-mcbr sam-mcbr commented Feb 7, 2025

Overview

This change allows for automated reconciliation of PVC autoresize annotations on STS provisioned PVCs. This is opt-in behavior so existing users won't be affected unless they want the functionality. This only manages the following annotations:

  • resize.topolvm.io/threshold
  • resize.topolvm.io/inodes-threshold
  • resize.topolvm.io/increase
  • resize.topolvm.io/storage_limit
  • resize.topolvm.io/initial-resize-group-by

Fixes #304

Testing

Unit tests were added covering both the new functionality and the new metrics associated with annotation patching.

Other

I made some other minor updates to the Makefile and unit test setup as the existing make test command was not working for me due to running in a subshell I believe. The unit test changes were only around setting the log level to debug as failing tests may be easier to debug that way. Happy to remove these changes if they are not desired.

@sam-mcbr sam-mcbr requested a review from a team as a code owner February 7, 2025 00:05
@sam-mcbr sam-mcbr requested review from toshipp and peng225 February 7, 2025 00:05
@sam-mcbr
Copy link
Contributor Author

sam-mcbr commented Feb 7, 2025

@llamerada-jp fyi. And please let me know if there was anything I missed. I tried to make sure this change was as safe as possible and tried to make all the associated updates (README, chart, etc.) but happy to update with any feedback/suggestions! Thank you so much!

@sam-mcbr
Copy link
Contributor Author

sam-mcbr commented Feb 7, 2025

@llamerada-jp Also the Lint and Test Charts failure is due to me bumping the image tag (which doesn't yet exist because a repo tag has not been cut yet). If you all would prefer I split the chart changes into a separate PR I'm happy to do that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Automatically patch desired annotations on STS-provisioned PVCs from the STS spec
1 participant