Patch annotations onto STS provisioned PVCs #306
+812
−37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This change allows for automated reconciliation of PVC autoresize annotations on STS provisioned PVCs. This is opt-in behavior so existing users won't be affected unless they want the functionality. This only manages the following annotations:
resize.topolvm.io/threshold
resize.topolvm.io/inodes-threshold
resize.topolvm.io/increase
resize.topolvm.io/storage_limit
resize.topolvm.io/initial-resize-group-by
Fixes #304
Testing
Unit tests were added covering both the new functionality and the new metrics associated with annotation patching.
Other
I made some other minor updates to the
Makefile
and unit test setup as the existingmake test
command was not working for me due to running in a subshell I believe. The unit test changes were only around setting the log level to debug as failing tests may be easier to debug that way. Happy to remove these changes if they are not desired.