Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dry-run option #129

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add dry-run option #129

wants to merge 5 commits into from

Conversation

Neal910
Copy link

@Neal910 Neal910 commented Aug 27, 2020

This PR is meant to tackle the issue of #117

Background:
I would like to output the prediction of a list of Rspec tests, so that the Knapsack Gem can accept the string and run the tests in parallel, as described here.

Personally, I came from Java world and am really new to the Ruby, actually this is my first Ruby project. Therefore, I am creating this prototype PR so that I can get more feedback in the beginning. Again, this PR is not meant to be merged but to discuss my proposal. All comments and suggestions are welcoming.

@pirj
Copy link
Contributor

pirj commented Aug 29, 2020

@EPecherkin @jaimerson @pluff I don't have the capacity for CrystalBall right now, appreciate if you could take this over.

@Neal910
Copy link
Author

Neal910 commented Sep 14, 2020

any suggestions are appreciated. Thanks guys.

lib/crystalball/rspec/runner.rb Outdated Show resolved Hide resolved
lib/crystalball/rspec/runner.rb Outdated Show resolved Hide resolved
lib/crystalball/rspec/runner.rb Outdated Show resolved Hide resolved
@jaimerson jaimerson changed the title WIP: prototype commit Add dry-run option Sep 14, 2020
@Neal910
Copy link
Author

Neal910 commented Sep 21, 2020

so far it's working with --dry-run , it's printing out the rspec list. Then I use sed to manipulate the output to be acceptable to Knapsack tools.

Feng Sha added 2 commits June 22, 2021 15:46
crystalball changes

See merge request devops/rts-crystalball!1
@jacob-s-son
Copy link

Hey, folks! I am planning to work on a POC next week to implement selective running of RSPEC and Cucumber tests that are load balanced by Knapsack Pro. Any guidance on the status of this PR? Any reason it can't be merged into mainstream? Maybe something I can help with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants