Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Box-Muller for truncated normal sampling #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions THRandom.c
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,31 @@ double THRandom_normal(THGenerator *_generator, double mean, double stdv)
return _generator->normal_rho*sin(2.*M_PI*_generator->normal_x)*stdv+mean;
}

double THRandom_normal_truncated(THGenerator *_generator, double mean, double stdv)
{
THArgCheck(stdv > 0, 2, "standard deviation must be strictly positive");

/* Using Box-Muller for truncated normal sampling
between -2*std and 2*std.
(based on Martino, L.; Luengo, D.; Míguez, J.
"Efficient sampling from truncated bivariate Gaussians
via Box-Muller transformation")*/
if(!_generator->normal_is_valid)
{
_generator->normal_x = __uniform__(_generator);
_generator->normal_y = __uniform__(_generator, 0, 1-exp(-2));
_generator->normal_rho = sqrt(-2. * log(1.0-_generator->normal_y));
_generator->normal_is_valid = 1;
}
else
_generator->normal_is_valid = 0;

if(_generator->normal_is_valid)
return _generator->normal_rho*cos(2.*M_PI*_generator->normal_x)*stdv+mean;
else
return _generator->normal_rho*sin(2.*M_PI*_generator->normal_x)*stdv+mean;
}

double THRandom_exponential(THGenerator *_generator, double lambda)
{
return(-1. / lambda * log(1-__uniform__(_generator)));
Expand Down