Skip to content

#3082 - IMAGES | Focal Point #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

#3082 - IMAGES | Focal Point #1079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1038d0d
Make sure none of the hero image is hidden
Apr 24, 2025
23bee72
Adjust max height to match with production
Apr 24, 2025
a0902c5
Remove unused templates
Apr 24, 2025
f174c20
Make the top of the hero image have a black background
Apr 24, 2025
70ff19e
Adjust max height of hero on desktop
Apr 25, 2025
753482f
Further adjust max height on desktop view
Apr 25, 2025
89ef8a3
Fix issue with height of hero changing depending on screen width on d…
Apr 28, 2025
ef5390f
Adjust margin on desktop width
Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion rca/project_styleguide/templates/patterns/molecules/hero/hero--programme.html
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions rca/project_styleguide/templates/patterns/molecules/hero/hero--programme.yaml
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions rca/project_styleguide/templates/patterns/molecules/hero/hero-schools.html
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions rca/project_styleguide/templates/patterns/molecules/hero/hero-schools.yaml
View file
Open in desktop

This file was deleted.

19 changes: 17 additions & 2 deletions rca/static_src/sass/components/_hero.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,28 @@
overflow: hidden;

&--medium {
max-height: 340px;
&::before {
@include z-index(under);
content: '';
background-color: $color--black;
height: 130px;
left: 0;
position: absolute;
top: 0;
width: 100%;
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scrolled down on both desktop and mobile:

Screenshot 2025-04-24 at 7 05 33 PM Screenshot 2025-04-24 at 7 05 40 PM


margin-top: 120px; // height of header
max-height: 170px;

@include media-query(medium) {
max-height: 536px;
margin-top: 130px;
max-height: 320px;
}

@include media-query(large) {
margin-top: 90px;
margin-bottom: -90px;
max-height: 780px;
}
}
Expand Down