#2490 - SPIKE: Research students unable to submit updates/content to their profiles #933
Conversation
Codecov Report
@@ Coverage Diff @@
## master #933 +/- ##
=======================================
Coverage 52.53% 52.53%
=======================================
Files 160 160
Lines 7522 7522
Branches 164 164
=======================================
Hits 3952 3952
Misses 3453 3453
Partials 117 117 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Thanks @patrickcuagan, if there is any time left one improvement here would be creating some more tests to visually check the presence of these fields (in case the templates are changed further)
Thanks Kev - I've added a test now. |
patrickcuagan
force-pushed
the
bugfix/2490-students-unable-to-submit
branch
from
a558322 to
53e2852
Compare
| GroupPagePermission.objects.create( | ||
| group=self.student_group, | ||
| page=self.student_index, | ||
| permission_type="edit", |
There was a problem hiding this comment.
Hi @patrickcuagan I needed to revert this work as it was pushed to dev and causing problem with deploying the Wagtail 5.1 upgrade to dev for testing.
My suggestion here is untested but reflects the changes required here: https://docs.wagtail.org/en/stable/releases/5.1.html#grouppagepermission-now-uses-django-s-permission-model
| permission_type="edit", | |
| permission=Permission.objects.get( | |
| content_type__app_label="wagtailcore", codename="change_page" | |
| ) |
It may be best to wait until the 5.1 upgrade has been deployed and the rebase your work to see the error in the test.
Ticket: https://projects.torchbox.com/projects/rca-django-cms-project/tickets/2490
This PR fixes an issue where the school field does not exist when a student edits their own page.
Issue: We're not rendering the form fields if a student is not logged in. The formset doesn't see those fields so an error is raised.