Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWE-10 - BE - Statistics group block (Division page) #328

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

SharmaineLim
Copy link
Collaborator

@SharmaineLim SharmaineLim commented Jan 6, 2025

Link to Ticket

Description of Changes Made

This ticket adds a new block for number statistics from the division page.

FE styling was done in #334 and has been merged in. You can use this to view only BE changes.

How to Test

  1. Create/Edit a division page.
  2. Try to add a new block in the Body field. You should see "Numeric statistics" as a block.
  3. Adding the "Numeric statistics" block and filling in the required fields should display the new content on the preview.

Screenshots

Division page editor

image

image

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Perfomance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@SharmaineLim SharmaineLim marked this pull request as ready for review January 6, 2025 11:28
@SharmaineLim SharmaineLim requested a review from ababic January 6, 2025 11:29
@SharmaineLim SharmaineLim removed the request for review from ababic January 10, 2025 11:48
Base automatically changed from feature/twe-7-division-page to integration/2024-evolution January 15, 2025 07:22
@SharmaineLim SharmaineLim force-pushed the feature/twe-10-stats-block branch from af9bb2b to 016f101 Compare January 15, 2025 07:50
@SharmaineLim SharmaineLim merged commit 41ee55b into integration/2024-evolution Jan 20, 2025
4 checks passed
@SharmaineLim SharmaineLim deleted the feature/twe-10-stats-block branch January 20, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants