Skip to content

Conversation

bmispelon
Copy link
Collaborator

@bmispelon bmispelon commented Apr 9, 2025

Link to Ticket

Description of Changes Made

This commit removes the filter tags from blog pages (both BlogPage and BlogIndexPage). Tags had already been hidden by 2d7b425 but this PR removes them from the code entirely (including the page metadata sent for analytics).

NOTE: I was not able to test the changes in the pattern library because I get an error on both blog_detail.html and blog_listing.html (other pages/patterns seem to work fine):

Firefox Can’t Open This Page

To protect your security, tbx.localhost will not allow Firefox to display the page if another site has embedded it. To see this page, you need to open it in a new window.

How to Test

Since the tags were already hidden there should not be any visual changes, but it's possible to view the difference on a BlogPage where the tags are now gone instead of being commented out in the HTML.

A unit test is also included which makes sure tags don't appear anywhere on the blog detail page (either visually or in the metadata).

Screenshots

N/A

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Performance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@bmispelon bmispelon force-pushed the TWE-58-be-remove-filter-tags-from-blogs branch from 1b6f723 to 2def615 Compare April 9, 2025 06:49
@bmispelon bmispelon marked this pull request as ready for review April 9, 2025 06:55
@bmispelon bmispelon requested a review from SharmaineLim April 9, 2025 06:55
@helenb
Copy link
Member

helenb commented Apr 9, 2025

Unfortunately it looks like all the pages in the pattern library are broken due to the get_top_level_parent_page tag. We probably just need to override this to fix it.

@bmispelon
Copy link
Collaborator Author

Unfortunately it looks like all the pages in the pattern library are broken due to the get_top_level_parent_page tag. We probably just need to override this to fix it.

I've pushed an extra commit to fix this by adding an override for the get_top_level_parent_page tag.

Copy link
Collaborator

@SharmaineLim SharmaineLim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@bmispelon bmispelon force-pushed the TWE-58-be-remove-filter-tags-from-blogs branch 2 times, most recently from b176d15 to 844617e Compare April 15, 2025 13:33
This breakage was introduced in be7d5ba
and made it so that all pages using or extending the base_page.html
template would not render in the pattern library.
@bmispelon bmispelon force-pushed the TWE-58-be-remove-filter-tags-from-blogs branch from 844617e to aa15091 Compare April 15, 2025 13:43
@bmispelon bmispelon merged commit cecaa0f into main Apr 15, 2025
4 checks passed
@bmispelon bmispelon deleted the TWE-58-be-remove-filter-tags-from-blogs branch April 15, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants