Skip to content

Conversation

bmispelon
Copy link
Collaborator

@bmispelon bmispelon commented Apr 17, 2025

Link to Ticket

Description of Changes Made

Add support for paragraphs in PromoBlock.description

How to Test

  1. Create (or edit) a page with a PromoBlock (like a ServiceAreaPage for example)
  2. Edit the "body" field to add a new "Promo" block
  3. In the "description" field, enter several paragraphs
  4. Save and view the page, observe that the paragraphs are visible (not just a single block of text)

Screenshots

Expand to see more

Screenshot 2025-04-17 at 10-38-32 Advocacy Engagement   Income Torchbox

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Performance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@bmispelon bmispelon marked this pull request as ready for review April 17, 2025 08:44
@albinazs albinazs self-requested a review April 17, 2025 09:06
Copy link
Collaborator

@albinazs albinazs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bmispelon - looks good to me!

This will enable editors to use paragraphs (and other
formatting options).
@bmispelon bmispelon force-pushed the TWE-63-render-paragraphs-for-promo-block-descriptions branch from c7f63f0 to f2f2f5a Compare April 17, 2025 10:00
@bmispelon bmispelon merged commit f8abfd3 into main Apr 17, 2025
4 checks passed
@bmispelon bmispelon deleted the TWE-63-render-paragraphs-for-promo-block-descriptions branch April 17, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants