Change 'id' argument's type to ID in site query

torchbox · Aug 30, 2023 · 0b72e6e · 0b72e6e
1 parent 4a7fc4e
commit 0b72e6e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/grapple/helpers.py b/grapple/helpers.py
@@ -74,7 +74,7 @@ def inner(cls):
         field_type = lambda: registry.models[cls]  # noqa: E731
         field_query_params = query_params
         if field_query_params is None:
-            field_query_params = {"id": graphene.Int()}
+            field_query_params = {"id": graphene.ID()}
 
             if issubclass(cls, Page):
                 field_query_params["slug"] = graphene.Argument(
@@ -194,7 +194,7 @@ def inner(cls):
         field_type = lambda: registry.models[cls]  # noqa: E731
         field_query_params = query_params
         if field_query_params is None:
-            field_query_params = {"id": graphene.Int()}
+            field_query_params = {"id": graphene.ID()}
 
             if issubclass(cls, Page):
                 field_query_params["slug"] = graphene.Argument(

diff --git a/grapple/types/sites.py b/grapple/types/sites.py
@@ -26,7 +26,7 @@ class SiteObjectType(DjangoObjectType):
     )
     page = graphene.Field(
         PageInterface,
-        id=graphene.Int(),
+        id=graphene.ID(),
         slug=graphene.String(),
         url_path=graphene.String(),
         token=graphene.String(),

diff --git a/tests/test_general.py b/tests/test_general.py
@@ -104,7 +104,7 @@ def test_query_field_plural(self):
 
     def test_query_field(self):
         query = """
-        query ($id: Int, $urlPath: String, $slug: String) {
+        query ($id: ID, $urlPath: String, $slug: String) {
             post(id: $id, urlPath: $urlPath, slug: $slug) {
                 id
                 urlPath
@@ -148,7 +148,7 @@ def test_query_field(self):
 
     def test_multiple_middleware(self):
         query = """
-        query ($id: Int) {
+        query ($id: ID) {
             middlewareModel(id: $id) {
                 id
             }
@@ -178,7 +178,7 @@ def setUp(self):
 
     def test_paginated_query_field(self):
         query = """
-        query ($id: Int, $urlPath: String, $slug: String) {
+        query ($id: ID, $urlPath: String, $slug: String) {
             blogPage(id: $id, urlPath: $urlPath, slug: $slug) {
                 id
                 urlPath
@@ -476,7 +476,7 @@ def test_query_field_with_logged_in_user_should_return_nothing(self):
         """
 
         query = """
-        query ($id: Int) {
+        query ($id: ID) {
             post(id: $id) {
                 id
                 urlPath
@@ -514,7 +514,7 @@ def test_paginated_query_field_with_logged_in_user_should_return_nothing(self):
         The query field was registered with the anonymous middleware, i.e. requires only anonymous users
         """
         query = """
-        query ($id: Int) {
+        query ($id: ID) {
             blogPage(id: $id) {
                 id
                 urlPath