Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug33545 043 #1842

Open
wants to merge 3 commits into
base: maint-0.4.3
Choose a base branch
from
Open

Bug33545 043 #1842

wants to merge 3 commits into from

Commits on Mar 30, 2020

  1. hs-v3: Don't allow registration of an all-zeroes client auth key.

    The client auth protocol allows attacker-controlled x25519 private keys being
    passed around, which allows an attacker to potentially trigger the all-zeroes
    assert for client_auth_sk in hs_descriptor.c:decrypt_descriptor_cookie().
    
    We fixed that by making sure that an all-zeroes client auth key will not be
    used.
    
    There are no guidelines for validating x25519 private keys, and the assert was
    there as a sanity check for code flow issues (we don't want to enter that
    function with an unitialized key if client auth is being used). To avoid such
    crashes in the future, we also changed the assert to a BUG-and-err.
    asn-d6 committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    b271f35 View commit details
    Browse the repository at this point in the history
  2. hs-v3: Change all-zeroes hard-assert to a BUG-and-err.

    And also disallow all-zeroes keys from the filesystem; add a test for it too.
    asn-d6 committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    a97e4a1 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2020

  1. Configuration menu
    Copy the full SHA
    7c49c70 View commit details
    Browse the repository at this point in the history