Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug34078 035 #1882

Open
wants to merge 7 commits into
base: maint-0.3.5
Choose a base branch
from
Open

Bug34078 035 #1882

wants to merge 7 commits into from

Commits on May 6, 2020

  1. Add a fallthrough macro. 

    This macro defers to __attribute__((fallthrough)) on GCC (and
clang).  Previously we had been using GCC's magic /* fallthrough */
comments, but clang very sensibly doesn't accept those.

Since not all compiler recognize it, we only define it when our
configure script detects that it works.

Part of a fix for 34078.
    @nmathewson
    nmathewson committed May 6, 2020
    Configuration menu
    Copy the full SHA
    6c3c943 View commit details
    Browse the repository at this point in the history

  2. Replace a "fall through" comment that was outside a switch.

    @nmathewson
    nmathewson committed May 6, 2020
    Configuration menu
    Copy the full SHA
    75547c0 View commit details
    Browse the repository at this point in the history

  3. Replace some "fall through" comments not at the end of a case.

    @nmathewson
    nmathewson committed May 6, 2020
    Configuration menu
    Copy the full SHA
    9fe23b8 View commit details
    Browse the repository at this point in the history

  4. include compat_compiler for ed25519_donna

    @nmathewson
    nmathewson committed May 6, 2020
    Configuration menu
    Copy the full SHA
    37b8324 View commit details
    Browse the repository at this point in the history

  5. address.c: add a single (harmless) missing break;

    @nmathewson
    nmathewson committed May 6, 2020
    Configuration menu
    Copy the full SHA
    8798c0a View commit details
    Browse the repository at this point in the history

  6. Remove an incorrect "Fall through" comment.

    @nmathewson
    nmathewson committed May 6, 2020
    Configuration menu
    Copy the full SHA
    3d36411 View commit details
    Browse the repository at this point in the history

  7. Use __attribute__((fallthrough)) rather than magic GCC comments. 

    GCC added an implicit-fallthrough warning a while back, where it
would complain if you had a nontrivial "case:" block that didn't end
with break, return, or something like that.  Clang recently added
the same thing.

GCC, however, would let you annotate a fall-through as intended by
any of various magic "/* fall through */" comments.  Clang, however,
only seems to like "__attribute__((fallthrough))".  Fortunately, GCC
accepts that too.

A previous commit in this branch defined a FALLTHROUGH macro to do
the right thing if GNUC is defined; here we replace all of our "fall
through" comments with uses of that macro.

This is an automated commit, made with the following perl one-liner:

  #!/usr/bin/perl -i -p
  s#/\* *falls? ?thr.*?\*/#FALLTHROUGH;#i;
    @nmathewson
    nmathewson committed May 6, 2020
    Configuration menu
    Copy the full SHA
    757a35c View commit details
    Browse the repository at this point in the history