Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: Catch missing Bridge for ClientTransportPlugin #2119

Open
wants to merge 1 commit into
base: maint-0.4.5
Choose a base branch
from
Open

config: Catch missing Bridge for ClientTransportPlugin #2119

wants to merge 1 commit into from

Commits on Nov 23, 2020

  1. config: Catch missing Bridge for ClientTransportPlugin 

    First of all, tor doesn't support multiple transport name on a single
*TransportPlugin line so get rid of that. The manpage has never documented
that feature and it complexifies the line for no reason. A user can just use
multiple ClientTransportPlugin line instead.

Second, if no Bridge line is found, error immediately and exit. Don't leave
the Bridge line alone there leading to bugs like #25528

Third, when making sure we have a Bridge line with a ClientTransportPlugin, we
now check at the managed proxy list. In order to pull this off, the transport
name had to be added to the managed_proxy_t object so we can match for which
transport it is used for. And thus justifying the removal of multiple
transport support which adds no benefit except complexity.

Fixes #40106

Signed-off-by: David Goulet <[email protected]>
    @dgoulet-tor
    dgoulet-tor committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    780f2d9 View commit details
    Browse the repository at this point in the history