Skip to content

Made it possible to pass the "index_type" argument in the Index and PartialIndex constructors #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Made it possible to pass the "index_type" argument in the Index and PartialIndex constructors #1368

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5420c0a
Made index_type a valid argument when creating an index
DeveloperAnonymous Apr 5, 2023
bf4856c
Made index_type a valid argument when creating an index
DeveloperAnonymous Apr 5, 2023
dd51a05
made index_type arg none for partialindex
DeveloperAnonymous Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions tortoise/indexes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ def __init__(
*expressions: Term,
fields: Optional[Tuple[str, ...]] = None,
name: Optional[str] = None,
index_type: Optional[str] = None
):
"""
All kinds of index parent class, default is BTreeIndex.
Expand All @@ -37,6 +38,8 @@ def __init__(
self.name = name
self.expressions = expressions
self.extra = ""
self.index_type = index_type or self.INDEX_TYPE


def get_sql(self, schema_generator: "BaseSchemaGenerator", model: "Type[Model]", safe: bool):
if self.fields:
Expand All @@ -45,7 +48,7 @@ def get_sql(self, schema_generator: "BaseSchemaGenerator", model: "Type[Model]",
index_name=schema_generator.quote(
self.name or schema_generator._generate_index_name("idx", model, self.fields)
),
index_type=f" {self.INDEX_TYPE} ",
index_type=f" {self.index_type} ",
table_name=schema_generator.quote(model._meta.db_table),
fields=", ".join(schema_generator.quote(f) for f in self.fields),
extra=self.extra,
Expand All @@ -55,7 +58,7 @@ def get_sql(self, schema_generator: "BaseSchemaGenerator", model: "Type[Model]",
return self.INDEX_CREATE_TEMPLATE.format(
exists="IF NOT EXISTS " if safe else "",
index_name=self.index_name(schema_generator, model),
index_type=f" {self.INDEX_TYPE} ",
index_type=f" {self.index_type} ",
table_name=schema_generator.quote(model._meta.db_table),
fields=", ".join(expressions),
extra=self.extra,
Expand All @@ -72,8 +75,9 @@ def __init__(
fields: Optional[Tuple[str, ...]] = None,
name: Optional[str] = None,
condition: Optional[dict] = None,
index_type: Optional[str] = None
):
super().__init__(*expressions, fields=fields, name=name)
super().__init__(*expressions, fields=fields, name=name, index_type=index_type)
if condition:
cond = " WHERE "
items = []
Expand Down