Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@toss/react): enhance Separated component #508

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

metacode22
Copy link

@metacode22 metacode22 commented Sep 2, 2024

Overview

I'm really enjoying using this Separated component. And I've thought of a few improvements.

  • Added first and last props to include separators at the beginning and end. dc41563
  • Preserved child element keys instead of replacing them with indexes. 67851af
  • Removed isValidElement filtering to support all ReactNode types. fa3e052
  • Added test code and documentation for these changes. 8666ba4 397626a

I hope you like it. Let me know if you'd like any adjustments. Thank you!

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

Copy link

vercel bot commented Sep 2, 2024

@metacode22 is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant