Migrate to material3 #211
Closed
Migrate to material3 #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I think I confused github as I merged after a rebase and some minor changes, but this is still "open". I assumed it would figure out that it was merged. Will see if I can get github to recognize that without closing it. |
serbelga
force-pushed
the
migrate_to_material3
branch
from
71af0a6
to
70d5658
Compare
|
I synced my branch with the latest changes to main and it automatically closed this PR. I see that my commits are now on the main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to use Material 3 in the
:shared-uimodule.I've been trying to use Material3 Compose components and themes in the views of the
shared-uimodule.The colors are generated from the Figma Material Theme Builder plugin https://www.figma.com/community/plugin/1034969338659738588/material-theme-builder. To improve visibility on light surfaces, I have set the blue that was being used as a secondary color as the primary color and the green that was used as the primary color as the secondary color.
Also, I have added the Montserrat font to adopt the same font used on the Droidcon website.
ℹ️ I have removed the two lines that specified the color of the status bar and navigation bar in themes.xml in the
androidmodule until using version 1.8.0 of Activity Compose that allows using theedgeToEdgeEnabled()method.ℹ️ I haven't migrated views in
androidmodule to Material3 because they seem to not been used and will be removed in #212Android
Light Theme
Dark Theme
iOS
Light Theme
Dark Theme