Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refund throtling and logging #2017

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Conversation

nkiryanov
Copy link
Contributor

Черновик тротлиннга + запись в журнал для возвратов.

@nkiryanov
Copy link
Contributor Author

@f213 глянь
Написать тесты на это не удалось — сетап чтоб запустить action для ModelAdmin не тривиальный получается и не уверен, что оно того стоит.

Чёт смущает как выглядит, но кажется на данном этапе выносить куда-то будет не лучше.

@nkiryanov nkiryanov requested a review from f213 October 1, 2023 18:17
Copy link
Contributor

@f213 f213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ок, давай оставим админку без тестов. Там нет бизнес-логики, так что думаю ничего страшного не случится

src/orders/human_readable.py Outdated Show resolved Hide resolved
src/orders/admin/orders/actions.py Outdated Show resolved Hide resolved
1. Simplify error message
2. Move `get_orders_identifiers` to orders admin module and rename
@nkiryanov nkiryanov marked this pull request as ready for review October 2, 2023 17:08
@nkiryanov nkiryanov merged commit bde0512 into master Oct 2, 2023
4 checks passed
@nkiryanov nkiryanov deleted the refund-throtling-and-logging branch October 2, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants