-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom admin site for reordering app list #2421
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ae827bb
Add custom admin site for reordering app list
AlexEbenrode 383b8d6
fix lint
AlexEbenrode 4d84788
fix after review
AlexEbenrode 7d26195
remove setting locale for test
AlexEbenrode 72f121e
fix type for get_app_list method
AlexEbenrode b9570bf
fix type
AlexEbenrode c49e00c
Merge branch 'master' into admin-dashboard-app-ordering
AlexEbenrode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,26 @@ | ||||||
from typing import Any | ||||||
|
||||||
from django.contrib import admin | ||||||
from django.http.request import HttpRequest | ||||||
|
||||||
|
||||||
class AdminSite(admin.AdminSite): | ||||||
def __init__(self, name: str) -> None: | ||||||
super().__init__(name=name) | ||||||
self._registry.update(admin.site._registry) | ||||||
|
||||||
def get_app_list(self, request: HttpRequest, app_label: str | None = None) -> list[dict]: | ||||||
app_list = super().get_app_list(request, app_label) | ||||||
app_list.sort(key=self._get_app_order_index) | ||||||
return app_list | ||||||
|
||||||
def _get_app_order_index(self, element: Any) -> int: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Тут же вроде dict, не? |
||||||
app_order = ["orders", "notion", "chains", "products", "otherapp"] | ||||||
|
||||||
if element["app_label"] in app_order: | ||||||
return app_order.index(element["app_label"]) | ||||||
|
||||||
return len(app_order) | ||||||
|
||||||
|
||||||
admin_site = AdminSite(name="custom_admin") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Этот метод не использует состояние класс, поэтому его лучше оформить как
@staticmethod
, чтобы в будущем, когда мы забудем что он делает, было бы легче это восстановить.