Lesson1 updates #68
Lesson1 updates #68
Conversation
AlexKupreev
force-pushed
the
lesson1
branch
6 times, most recently
from
9d4c410
to
108668f
Compare
AlexKupreev
force-pushed
the
lesson1
branch
from
108668f
to
a010229
Compare
| @@ -66,6 +66,7 @@ dennis = "^1.1" | |||
| dump-env = "^1.3" | |||
| ipython = "^8.15" | |||
| import-linter = "^1.11" | |||
| mimesis = "^11.1.0" | |||
There was a problem hiding this comment.
Минорный момент: лучше не продуктовые зависимости добавлять в dev группу.
Например, это можно сделать командой poetry add --group dev xxx или вручную переставить в файле.
There was a problem hiding this comment.
оно вроде и есть в dev-зависимостях?
tests/test_server/test_urls.py
Outdated
| email, | ||
| password, | ||
| ) | ||
| client.force_login(user) |
There was a problem hiding this comment.
Вот этот юзер для апдейта классно бы смотрелся в фикстуре.
tests/test_server/test_urls.py
Outdated
| response = client.get('/pictures/dashboard') | ||
| assert response.status_code == HTTPStatus.OK | ||
|
|
||
| response = client.get('/pictures/favourites') |
There was a problem hiding this comment.
Тут чтобы меньше повторяться, можно применить pytest.mark.parametrize, например:
@pytest.mark.parametrize('endpoint', [
'/pictures/dashboard',
'/pictures/favourites',
])
def test_picture_pages_authorized(
client: Client,
django_user_model: User,
endpoint: str,
) -> None:
...
AlexKupreev
force-pushed
the
lesson1
branch
from
73203ab
to
1ec0e1f
Compare
| @@ -2,6 +2,11 @@ | |||
|
|
|||
| import pytest | |||
| from django.test import Client | |||
| from plugins.identity.user import ( | |||
| ProfileAssertion, | |||
| ProfileDataFactory, | |||
There was a problem hiding this comment.
question: If we treat plugins as standalone modules, will this affect test or CI duration?
As @sobolevn suggested, we could remove __init__.py from the plugin subdirectories. We should then import classes only for type checking under the TYPE_CHECKING condition.
If plugins become significantly large, will this change influence the startup time or CI duration?
There was a problem hiding this comment.
As far as I understand, TYPE_CHECKING was used in the presented code examples for the case of mypy type check - if mypy is not used, switching them off may speed up a bit.
I'm not really sure about __init__.py and auto-importing, but afaik they are imported only once per execution, not sure that might save a lot of time.
No description provided.