Conversation
This fixes a bunch of minor clippy lints. None of them were particularly major, but I was getting tired of the warnings showing up in vscode. The one lint that had to be ignored rather than fixed is the `clippy::bool_assert_comparison` lint, which triggers on the `tower_test::assert_request_eq!` macro. The lint triggers when writing code like `assert_eq!(whatever, true)` rather than simply `assert!(whatever)`. In this case, this occurs because the macro makes an assertion about a request value, and in _some_ tests, the request type is `bool`. We can't change this to use `assert!`, because in most cases, when the request is not `bool`, we actually do need `assert_eq!`, so I ignored that warning.
Member
Author
|
The build failure appears to be due to a compiler regression (rust-lang/rust#93821). I believe there's a PR fixing it (rust-lang/rust#93893), but it's not in yesterday's nightly. Because our CI is currently configured with fail-fast enabled for the cross-version test jobs, we don't get to see the results of the builds on versions other than nightly, so it's not obvious that this is a nightly-specific issue. I opened #640 to change the CI configuration to not do that.
|
LucioFranco
approved these changes
Feb 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bunch of minor clippy lints. None of them were particularly
major, but I was getting tired of the warnings showing up in vscode.
The one lint that had to be ignored rather than fixed is the
clippy::bool_assert_comparisonlint, which triggers on thetower_test::assert_request_eq!macro. The lint triggers when writingcode like
assert_eq!(whatever, true)rather than simplyassert!(whatever). In this case, this occurs because the macro makesan assertion about a request value, and in some tests, the request
type is
bool. We can't change this to useassert!, because in mostcases, when the request is not
bool, we actually do needassert_eq!,so I ignored that warning.