Skip to content

feat!: fix node_api_create_object_with_properties name #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toyobayashi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat!: fix node_api_create_object_with_properties name #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/emnapi/include/node/js_native_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,12 @@ NAPI_EXTERN napi_status NAPI_CDECL napi_create_object(napi_env env,
#ifdef NAPI_EXPERIMENTAL
#define NODE_API_EXPERIMENTAL_HAS_CREATE_OBJECT_WITH_PROPERTIES
NAPI_EXTERN napi_status NAPI_CDECL
napi_create_object_with_properties(napi_env env,
napi_value prototype_or_null,
napi_value* property_names,
napi_value* property_values,
size_t property_count,
napi_value* result);
node_api_create_object_with_properties(napi_env env,
napi_value prototype_or_null,
napi_value* property_names,
napi_value* property_values,
size_t property_count,
napi_value* result);
#endif // NAPI_EXPERIMENTAL

NAPI_EXTERN napi_status NAPI_CDECL napi_create_array(napi_env env,
Expand Down
2 changes: 1 addition & 1 deletion packages/emnapi/src/value/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ export function napi_create_object (env: napi_env, result: Pointer<napi_value>):
/**
* @__sig ipppppp
*/
export function napi_create_object_with_properties (
export function node_api_create_object_with_properties (
env: napi_env,
prototype_or_null: napi_value,
property_names: Pointer<napi_value>,
Expand Down
10 changes: 5 additions & 5 deletions packages/test/object/test_object.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,7 @@ static napi_value TestCreateObjectWithProperties(napi_env env,
napi_value null_prototype;
NODE_API_CALL(env, napi_get_null(env, &null_prototype));
NODE_API_CALL(env,
napi_create_object_with_properties(
node_api_create_object_with_properties(
env, null_prototype, names, values, 3, &result));

return result;
Expand All @@ -753,9 +753,9 @@ static napi_value TestCreateObjectWithPropertiesEmpty(napi_env env,
napi_callback_info info) {
napi_value result;

NODE_API_CALL(
env,
napi_create_object_with_properties(env, NULL, NULL, NULL, 0, &result));
NODE_API_CALL(env,
node_api_create_object_with_properties(
env, NULL, NULL, NULL, 0, &result));

return result;
}
Expand Down Expand Up @@ -788,7 +788,7 @@ static napi_value TestCreateObjectWithCustomPrototype(napi_env env,
NODE_API_CALL(env, napi_create_int32(env, 42, &values[0]));

NODE_API_CALL(env,
napi_create_object_with_properties(
node_api_create_object_with_properties(
env, prototype, names, values, 1, &result));

return result;
Expand Down