Skip to content

Commit

Permalink
Refactor integration tests
Browse files Browse the repository at this point in the history
  • Loading branch information
tparviainen committed Jan 27, 2024
1 parent f194bab commit 526e551
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/ClashOfClans.Tests.Integration/ClansTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ public async Task RetrieveClansClanWarLog()
}

// Assert
Assert.IsTrue(taskList.Any(), "Test data does not contain a clan with public war log!");
Assert.IsTrue(taskList.Count != 0, "Test data does not contain a clan with public war log!");

foreach (ClanWarLog warLog in (await Task.WhenAll(taskList)).Select(v => (ClanWarLog)v))
{
Expand All @@ -214,7 +214,7 @@ public async Task RetrieveInformationAboutClansCurrentClanWar()
clanTags.ForEach(clanTag => taskList.Add(_coc.Clans.GetCurrentWarAsync(clanTag)));

// Assert
Assert.IsTrue(taskList.Any(), "Test data does not contain a clan with public war log!");
Assert.IsTrue(taskList.Count != 0, "Test data does not contain a clan with public war log!");

foreach (var currentWar in await Task.WhenAll(taskList))
{
Expand Down
5 changes: 3 additions & 2 deletions src/ClashOfClans.Tests.Integration/DumpExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,13 @@ public static string Dump(this ClanWarLeagueWarClan clan)
private static string Dump(string players, IOrderedEnumerable<ClanWarMember> members)
{
var sb = new StringBuilder();
var membersArray = members.ToArray();

if (members.Any())
if (membersArray.Length != 0)
{
sb.Append(players);
sb.Append(Environment.NewLine);
foreach (var member in members)
foreach (var member in membersArray)
{
sb.Append(member.Dump());
sb.Append(Environment.NewLine);
Expand Down

0 comments on commit 526e551

Please sign in to comment.