feat: #178 Remove obsolete APIs (#179)

Remove GetClanVersusRankingAsync and GetPlayerVersusRankingAsync APIs because they do not exist anymore.
tparviainen · Dec 18, 2023 · af3d0bc · af3d0bc
1 parent 2f72e94
commit af3d0bc
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 156 deletions.
diff --git a/src/ClashOfClans.Models/ClanVersusRanking.cs b/src/ClashOfClans.Models/ClanVersusRanking.cs
diff --git a/src/ClashOfClans.Models/ClanVersusRankingList.cs b/src/ClashOfClans.Models/ClanVersusRankingList.cs
diff --git a/src/ClashOfClans.Models/PlayerVersusRanking.cs b/src/ClashOfClans.Models/PlayerVersusRanking.cs
diff --git a/src/ClashOfClans.Models/PlayerVersusRankingList.cs b/src/ClashOfClans.Models/PlayerVersusRankingList.cs
diff --git a/src/ClashOfClans.Tests.Integration/LocationsTests.cs b/src/ClashOfClans.Tests.Integration/LocationsTests.cs
@@ -119,42 +119,6 @@ public async Task GetPlayerRankingsForASpecificLocation()
             Assert.IsTrue(playerRankingList.Count <= ItemLimit, $"Id {location.Id}");
         }
 
-        [TestMethod]
-        public async Task GetClanVersusRankingsForASpecificLocation()
-        {
-            // Arrange
-            var location = GetRandom(_locations, l => l.IsCountry);
-            var query = new Query
-            {
-                Limit = ItemLimit
-            };
-
-            // Act
-            var clanRankingList = (ClanVersusRankingList)await _coc.Locations.GetClanVersusRankingAsync(location.Id, query);
-
-            // Assert
-            Assert.IsNotNull(clanRankingList);
-            Assert.AreEqual(ItemLimit, clanRankingList.Count, $"Id {location.Id}");
-        }
-
-        [TestMethod]
-        public async Task GetPlayerVersusRankingsForASpecificLocation()
-        {
-            // Arrange
-            var location = GetRandom(_locations, l => l.IsCountry);
-            var query = new Query
-            {
-                Limit = ItemLimit
-            };
-
-            // Act
-            var playerVersusRankingList = (PlayerVersusRankingList)await _coc.Locations.GetPlayerVersusRankingAsync(location.Id, query);
-
-            // Assert
-            Assert.IsNotNull(playerVersusRankingList);
-            Assert.IsTrue(playerVersusRankingList.Count <= ItemLimit, $"Id {location.Id}");
-        }
-
         [TestMethod]
         public async Task GetCapitalRankingsForASpecificLocation()
         {

diff --git a/src/ClashOfClans/Api/Locations.cs b/src/ClashOfClans/Api/Locations.cs
@@ -60,30 +60,6 @@ public Task<QueryResult<PlayerRankingList>> GetPlayerRankingAsync(int? locationI
             return _gameData.QueryAsync<PlayerRankingList>(request);
         }
 
-        public Task<QueryResult<ClanVersusRankingList>> GetClanVersusRankingAsync(int? locationId, Query? query = default)
-        {
-            var request = new AutoValidatedRequest
-            {
-                Query = query,
-                LocationId = locationId,
-                Uri = $"/locations/{locationId}/rankings/clans-versus"
-            };
-
-            return _gameData.QueryAsync<ClanVersusRankingList>(request);
-        }
-
-        public Task<QueryResult<PlayerVersusRankingList>> GetPlayerVersusRankingAsync(int? locationId, Query? query = default)
-        {
-            var request = new AutoValidatedRequest
-            {
-                Query = query,
-                LocationId = locationId,
-                Uri = $"/locations/{locationId}/rankings/players-versus"
-            };
-
-            return _gameData.QueryAsync<PlayerVersusRankingList>(request);
-        }
-
         public Task<QueryResult<ClanCapitalRankingList>> GetClanCapitalRankingAsync(int? locationId, Query? query = default)
         {
             var request = new AutoValidatedRequest

diff --git a/src/ClashOfClans/ILocations.cs b/src/ClashOfClans/ILocations.cs
@@ -48,28 +48,6 @@ public interface ILocations
         /// <returns>Player ranking list</returns>
         Task<QueryResult<PlayerRankingList>> GetPlayerRankingAsync(int? locationId, Query? query = default);
 
-        /// <summary>
-        /// Get clan versus rankings for a specific location
-        /// </summary>
-        /// <param name="locationId">Identifier of the location to retrieve</param>
-        /// <param name="query">Optional query parameters</param>
-        /// <exception cref="Core.ClashOfClansException">Communication error with the backend API</exception>
-        /// <exception cref="System.ArgumentException">Argument is invalid</exception>
-        /// <returns>Clan ranking list</returns>
-        [Obsolete("This route is deprecated and will be removed in the future. Call GetClanBuilderBaseRankingAsync instead.")]
-        Task<QueryResult<ClanVersusRankingList>> GetClanVersusRankingAsync(int? locationId, Query? query = default);
-
-        /// <summary>
-        /// Get player versus rankings for a specific location
-        /// </summary>
-        /// <param name="locationId">Identifier of the location to retrieve</param>
-        /// <param name="query">Optional query parameters</param>
-        /// <exception cref="Core.ClashOfClansException">Communication error with the backend API</exception>
-        /// <exception cref="System.ArgumentException">Argument is invalid</exception>
-        /// <returns>Player versus ranking list</returns>
-        [Obsolete("This route is deprecated and will be removed in the future. Call GetPlayerBuilderBaseRankingAsync instead.")]
-        Task<QueryResult<PlayerVersusRankingList>> GetPlayerVersusRankingAsync(int? locationId, Query? query = default);
-
         /// <summary>
         /// Get capital rankings for a specific location
         /// </summary>