Skip to content

Commit

Permalink
Remove references to VersusAbc properties and use BuilderBaseAbc instead
Browse files Browse the repository at this point in the history
  • Loading branch information
tparviainen committed Jan 27, 2024
1 parent fd04477 commit beb8498
Show file tree
Hide file tree
Showing 7 changed files with 2 additions and 39 deletions.
4 changes: 2 additions & 2 deletions src/ClashOfClans.App/Examples/LocationsExamples.cs
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public async Task GetClanBuilderBaseRankingsForASpecificLocation()

foreach (var clan in clanBuilderBaseRankings)
{
Console.WriteLine($"{clan.Rank}. {clan.Name}, clan level {clan.ClanLevel}, {clan.ClanVersusPoints} \uD83C\uDFC6");
Console.WriteLine($"{clan.Rank}. {clan.Name}, clan level {clan.ClanLevel}, {clan.ClanBuilderBasePoints} \uD83C\uDFC6");
}
}

Expand All @@ -114,7 +114,7 @@ public async Task GetPlayerBuilderBaseRankingsForASpecificLocation()

foreach (var player in playerBuilderBaseRankings)
{
Console.WriteLine($"Rank {player.Rank}, {player.VersusTrophies} \uD83C\uDFC6, player {player.Name}");
Console.WriteLine($"Rank {player.Rank}, {player.BuilderBaseTrophies} \uD83C\uDFC6, player {player.Name}");
}
}

Expand Down
6 changes: 0 additions & 6 deletions src/ClashOfClans.Models/Clan.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,8 @@ public class Clan : Identity
private int? _clanLevel;
private int? _clanPoints;
private int? _clanBuilderBasePoints;
private int? _clanVersusPoints;
private int? _clanCapitalPoints;
private int? _requiredTrophies;
private int? _requiredVersusTrophies;
private int? _requiredTownhallLevel;
private WarFrequency? _warFrequency;
private int? _warWinStreak;
Expand Down Expand Up @@ -40,17 +38,13 @@ public class Clan : Identity

public int ClanBuilderBasePoints { get => _clanBuilderBasePoints ?? default; set => _clanBuilderBasePoints = value; }

public int ClanVersusPoints { get => _clanVersusPoints ?? default; set => _clanVersusPoints = value; }

public int ClanCapitalPoints { get => _clanCapitalPoints ?? default; set => _clanCapitalPoints = value; }

/// <summary>
/// Minimum trophies to join
/// </summary>
public int RequiredTrophies { get => _requiredTrophies ?? default; set => _requiredTrophies = value; }

public int RequiredVersusTrophies { get => _requiredVersusTrophies ?? default; set => _requiredVersusTrophies = value; }

public int RequiredTownhallLevel { get => _requiredTownhallLevel ?? default; set => _requiredTownhallLevel = value; }

public ClanCapital? ClanCapital { get; set; }
Expand Down
3 changes: 0 additions & 3 deletions src/ClashOfClans.Models/ClanBuilderBaseRanking.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ public class ClanBuilderBaseRanking : Identity
private int? _rank;
private int? _previousRank;
private int? _clanBuilderBasePoints;
private int? _clanVersusPoints;

public Location? Location { get; set; }

Expand All @@ -21,8 +20,6 @@ public class ClanBuilderBaseRanking : Identity

public int ClanBuilderBasePoints { get => _clanBuilderBasePoints ?? default; set => _clanBuilderBasePoints = value; }

public int ClanVersusPoints { get => _clanVersusPoints ?? default; set => _clanVersusPoints = value; }

public UrlContainer BadgeUrls { get; set; } = default!;
}
}
3 changes: 0 additions & 3 deletions src/ClashOfClans.Models/ClanMember.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ public class ClanMember : Identity
private int? _townHallLevel;
private int? _trophies;
private int? _builderBaseTrophies;
private int? _versusTrophies;
private int? _clanRank;
private int? _previousClanRank;
private int? _donations;
Expand All @@ -27,8 +26,6 @@ public class ClanMember : Identity

public int BuilderBaseTrophies { get => _builderBaseTrophies ?? default; set => _builderBaseTrophies = value; }

public int VersusTrophies { get => _versusTrophies ?? default; set => _versusTrophies = value; }

public int ClanRank { get => _clanRank ?? default; set => _clanRank = value; }

public int PreviousClanRank { get => _previousClanRank ?? default; set => _previousClanRank = value; }
Expand Down
15 changes: 0 additions & 15 deletions src/ClashOfClans.Models/Player.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,11 @@ public class Player : Identity
private int? _warStars;
private int? _attackWins;
private int? _defenseWins;
private int? _versusTrophies;
private int? _bestVersusTrophies;
private int? _versusBattleWins;
private int? _donations;
private int? _donationsReceived;
private int? _builderBaseTrophies;
private int? _bestBuilderBaseTrophies;
private int? _clanCapitalContributions;
private int? _versusBattleWinCount;

public int TownHallLevel { get => _townHallLevel ?? default; set => _townHallLevel = value; }

Expand Down Expand Up @@ -49,15 +45,6 @@ public class Player : Identity

public int? BuilderHallLevel { get; set; }

public int VersusTrophies { get => _versusTrophies ?? default; set => _versusTrophies = value; }

/// <summary>
/// All time best
/// </summary>
public int BestVersusTrophies { get => _bestVersusTrophies ?? default; set => _bestVersusTrophies = value; }

public int VersusBattleWins { get => _versusBattleWins ?? default; set => _versusBattleWins = value; }

public Role? Role { get; set; }

public WarPreference? WarPreference { get; set; }
Expand Down Expand Up @@ -89,8 +76,6 @@ public class Player : Identity

public PlayerAchievementProgressList Achievements { get; set; } = default!;

public int VersusBattleWinCount { get => _versusBattleWinCount ?? default; set => _versusBattleWinCount = value; }

public PlayerItemLevelList Troops { get; set; } = default!;

public PlayerItemLevelList Heroes { get; set; } = default!;
Expand Down
6 changes: 0 additions & 6 deletions src/ClashOfClans.Models/PlayerBuilderBaseRanking.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ public class PlayerBuilderBaseRanking : Identity
private int? _rank;
private int? _previousRank;
private int? _builderBaseTrophies;
private int? _versusTrophies;
private int? _versusBattleWins;

public int ExpLevel { get => _expLevel ?? default; set => _expLevel = value; }

Expand All @@ -17,10 +15,6 @@ public class PlayerBuilderBaseRanking : Identity

public int BuilderBaseTrophies { get => _builderBaseTrophies ?? default; set => _builderBaseTrophies = value; }

public int VersusTrophies { get => _versusTrophies ?? default; set => _versusTrophies = value; }

public int VersusBattleWins { get => _versusBattleWins ?? default; set => _versusBattleWins = value; }

public PlayerRankingClan? Clan { get; set; }

public BuilderBaseLeague BuilderBaseLeague { get; set; } = default!;
Expand Down
4 changes: 0 additions & 4 deletions src/ClashOfClans.Models/PlayerLegendStatistics.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ public class PlayerLegendStatistics

public int LegendTrophies { get => _legendTrophies ?? default; set => _legendTrophies = value; }

public LegendLeagueTournamentSeasonResult? BestVersusSeason { get; set; }

public LegendLeagueTournamentSeasonResult? PreviousVersusSeason { get; set; }

public LegendLeagueTournamentSeasonResult? BestSeason { get; set; }

public LegendLeagueTournamentSeasonResult CurrentSeason { get; set; } = default!;
Expand Down

0 comments on commit beb8498

Please sign in to comment.