This is a fix for pyperry from Ryan #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the necessity of it more
|
If you throw a test in there for this I can merge it in now and roll a new version, but otherwise I'll just wait until I get back. Thanks! |
|
@tpett What actually be a good contributor? I think not. I'm actually looking at this and it fails one of your tests. Let's look at when you get back, as I'm not sure it's working exactly as expected. I don't know enough about the context Ryan needed it for to make a good call. Thanks anyway. |
|
@jcredding @tpett - is this still relevant?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an issue for it ticket no. 22620. I'm not exactly sure what was broken and what it fixed, but wanted to get this to you easily.