Merge pull request #8 from tprzytula/development

Refactored client/server unit tests & coverage

.eslintrc

@@ -16,7 +16,9 @@
   "globals": {
     "Meteor": true,
     "it": true,
-    "describe": true
+    "describe": true,
+    "beforeEach": true,
+    "afterEach": true
   },
   "rules": {
     "comma-dangle": [
@@ -34,6 +36,8 @@
       "never"
     ],
     "no-underscore-dangle": 0,
-    "no-console": 0
+    "no-console": 0,
+    "one-var-declaration-per-line": 0,
+    "one-var": 0
   }
 }

.gitignore

@@ -1,3 +1,4 @@
 .idea
+.coverage
 node_modules/
 npm-debug.log

.meteor/packages

@@ -7,16 +7,17 @@
 [email protected]             # Packages every Meteor app needs to have
 [email protected]       # Packages for a great mobile UX
 [email protected]                   # The database Meteor supports right now
-[email protected] # Compile .html files into Meteor Blaze views
-[email protected]            # Reactive variable for tracker
+[email protected]    # Compile .html files into Meteor Blaze views
+[email protected]           # Reactive variable for tracker
 [email protected]                 # Meteor's client-side reactive programming library
 
 [email protected]   # CSS minifier run for production mode
 [email protected]    # JS minifier run for production mode
 [email protected]                # ECMAScript 5 compatibility for older browsers
-[email protected]              # Enable ECMAScript2015+ syntax in app code
+[email protected]             # Enable ECMAScript2015+ syntax in app code
 [email protected]            # Server-side component of the `meteor shell` command
 
 tprzytula:remember-me
 accounts-base
 meteortesting:mocha
+lmieulet:meteor-coverage

.meteorignore

@@ -1 +1,2 @@
-package.js
+package.js
+.coverage

.npmignore

@@ -17,3 +17,4 @@ appveyor.yml
 .travis.yml
 node_modules
 npm-debug.log
+.coverage

.travis.yml

@@ -7,4 +7,6 @@ addons:
 before_install:
   - "curl -L https://raw.githubusercontent.com/arunoda/travis-ci-meteor-packages/dca8e51fafd60d9e5a8285b07ca34a63f22a5ed4/configure.sh | /bin/sh"
 before_script:
-  - "export PATH=$HOME/.meteor:$PATH"
+  - "export PATH=$HOME/.meteor:$PATH"
+after_success:
+  - npm run coveralls

README.md

@@ -1,4 +1,5 @@
-# Meteor - Remember Me
+# Meteor - Remember Me 
+[![Build Status](https://travis-ci.org/tprzytula/Meteor-Remember-Me.svg?branch=master)](https://travis-ci.org/tprzytula/Meteor-Remember-Me) [![Coverage Status](https://coveralls.io/repos/github/tprzytula/Meteor-Remember-Me/badge.svg)](https://coveralls.io/github/tprzytula/Meteor-Remember-Me)
 ### Integrated remember me functionality support for Meteor
 
 

client/index.js

@@ -135,6 +135,7 @@ class RememberMe {
         }
 
         /* eslint-disable */
+        /* istanbul ignore next */
         /*
             The method is based on the original one in Accounts:
             https://github.com/meteor/meteor/blob/46257bad264bf089e35e0fe35494b51fe5849c7b/packages/accounts-password/password_client.js#L33

package.json

@@ -19,14 +19,16 @@
     "eslint": "eslint ./client ./server ./test || true",
     "eslint-check": "eslint ./client ./server ./test",
     "eslint-fix": "eslint ./client ./server ./test --fix || true",
-    "test": "cross-env TEST_BROWSER_DRIVER=chrome meteor test --once --driver-package meteortesting:mocha",
-    "test-watch": "cross-env WATCH=1 TEST_BROWSER_DRIVER=chrome meteor test --driver-package meteortesting:mocha"
+    "test": "cross-env TEST_BROWSER_DRIVER=chrome COVERAGE=1 COVERAGE_OUT_LCOVONLY=1 COVERAGE_OUT_HTML=1 COVERAGE_OUT_TEXT_SUMMARY=1 COVERAGE_APP_FOLDER=$PWD/ meteor test --once --driver-package meteortesting:mocha",
+    "test-watch": "cross-env WATCH=1 TEST_BROWSER_DRIVER=chrome meteor test --driver-package meteortesting:mocha",
+    "coveralls": "cat .coverage/lcov.info | coveralls"
   },
   "devDependencies": {
     "@babel/runtime": "^7.0.0-beta.44",
     "babel-eslint": "^8.2.2",
     "bcrypt": "^2.0.0",
     "chromedriver": "^2.37.0",
+    "coveralls": "^3.0.1",
     "cross-env": "^5.1.4",
     "eslint": "4.18.2",
     "eslint-config-airbnb-base": "^12.1.0",

test/client/helpers.spec.js

@@ -0,0 +1,121 @@
+const { exportFlagFromParams, exportCallbackFromParams } = require('./../../client/helpers');
+const chai = require('ultimate-chai');
+
+const { expect } = chai;
+
+describe('Given exportFlagFromParams', () => {
+    const sampleFlag = false;
+    const sampleMethod = () => {};
+    let result;
+
+    describe('When rememberMe flag is a first param', () => {
+        beforeEach(() => {
+            result = exportFlagFromParams([sampleFlag]);
+        });
+
+        it('should return the flag', () => {
+            expect(result).to.be.equal(sampleFlag);
+        });
+    });
+
+    describe('When rememberMe flag is a second param', () => {
+        beforeEach(() => {
+            result = exportFlagFromParams([sampleMethod, sampleFlag]);
+        });
+
+        it('should return the flag', () => {
+            expect(result).to.be.equal(sampleFlag);
+        });
+    });
+
+    describe('When parameters are only containing a method', () => {
+        beforeEach(() => {
+            result = exportFlagFromParams([sampleMethod]);
+        });
+
+        it('should return true as default', () => {
+            expect(result).to.be.equal(true);
+        });
+    });
+
+    describe('When the parameters are empty', () => {
+        beforeEach(() => {
+            result = exportFlagFromParams([]);
+        });
+
+        it('should return true as default', () => {
+            expect(result).to.be.equal(true);
+        });
+    });
+
+    describe('When nothing is passed to the method', () => {
+        beforeEach(() => {
+            result = exportFlagFromParams();
+        });
+
+        it('should return true as default', () => {
+            expect(result).to.be.equal(true);
+        });
+    });
+});
+
+describe('Given exportCallbackFromParams', () => {
+    const sampleMethod = () => {};
+    let result;
+
+    describe('When function is a first param', () => {
+        beforeEach(() => {
+            result = exportCallbackFromParams([sampleMethod, 1, 'abc']);
+        });
+
+        it('should return the same method', () => {
+            expect(result).to.be.equal(sampleMethod);
+        });
+    });
+
+    describe('When function is a second param', () => {
+        beforeEach(() => {
+            result = exportCallbackFromParams([1, sampleMethod, 'abc']);
+        });
+
+        it('should return a function', () => {
+            expect(typeof result).to.be.equal('function');
+        });
+
+        describe('And the returned function', () => {
+            it('should not be the same as the one in params', () => {
+                expect(result).to.not.be.equal(sampleMethod);
+            });
+        });
+    });
+
+    describe('When function is not in parameters', () => {
+        beforeEach(() => {
+            result = exportCallbackFromParams([1, 'abc']);
+        });
+
+        it('should return a function', () => {
+            expect(typeof result).to.be.equal('function');
+        });
+    });
+
+    describe('When the parameters are empty', () => {
+        beforeEach(() => {
+            result = exportCallbackFromParams([]);
+        });
+
+        it('should return a function', () => {
+            expect(typeof result).to.be.equal('function');
+        });
+    });
+
+    describe('When nothing is passed to the method', () => {
+        beforeEach(() => {
+            result = exportCallbackFromParams();
+        });
+
+        it('should return a function', () => {
+            expect(typeof result).to.be.equal('function');
+        });
+    });
+});