This repository has been archived by the owner on May 1, 2023. It is now read-only.
Remove redundant and erroneous function call from FA1.2 Doc Tutorial #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While learning about the Tezos developer ecosystem, I've discovered what I believe to be an error in the documentation page found here:
https://assets.tqtezos.com/docs/token-contracts/fa12/2-fa12-ligo/
The code to highlight is:
I believe the call to
Tezos.setProvider(...)
is unnecessary for two reasons:importKey
states that the function has a "side-effect" of setting the Tezos instance's signer to the InMemorySigner making theTezos.setProvider(...
call redundant.Solution
My pull request removes the redundant call and the InMemorySigner import.