This repository has been archived by the owner on Aug 4, 2023. It is now read-only.
changed bid raise logic and updates tests #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EGuenz
force-pushed
the
eli/and_based_raise
branch
from
e80d3d1
to
26504c9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past version of english auction contracts, a subsequent bid needed to be greater than either the
min_raise_percentof the previous bid, OR it needed to be greater than the sum of the previous bid and themin_raise. This PR changes the logic to be AND instead of OR. In other words, a new bid must satisfy both the percentage raise requirements as well as the min raise logic.