-
-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement #314
base: master
Are you sure you want to change the base?
Improvement #314
Conversation
Added the report interval to the report in order to detect if the client has lost connection
Can you please explain the use case. |
@tananaev When the device sends a report, the device sends its report interval so the sever knows when to excpect the next report. |
Are you planning to implement some modifications on the server side as well? What about iOS? |
Maybe not right now, but possible to do that in the near future. |
OK, we can merge when everything is ready. Also, the right way of implementing this would be to add a new parameter to the |
I'm not sure if that's correct, the interval isn't really a part of the Position model attributes (logically). |
I think it makes sense to send original interval value at the time when location was captured. |
If you think this is the best approach we can do that, but I'm not sure that's the right way logically. What exactly do I need to change in the server? |
We can either keep server as it is, but ideally we want to use interval for "unknown" status timeout. |
Ok, I'll keep you updated. Thanks. |
I like this idea, and would find it useful. |
Added the report interval to the report in order to detect if the client has lost connection