keep old behaviour in RoutePath when we just have coordinates (and no… #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… positions) include name property in both cases.
|
any comments? |
|
I think we should probably split |
|
can you check? |
tananaev
reviewed
Jun 30, 2024
src/map/MapRoutePath.js
Outdated
| import { map } from './core/MapView'; | ||
| import { getSpeedColor } from '../common/util/colors'; | ||
|
|
||
| const MapRoutePath = ({ name, positions, coordinates }) => { | ||
| const MapRoutePath = ({ name, positions }) => { |
There was a problem hiding this comment.
It looks like name is never used. We can probably remove it from here.
tananaev
reviewed
Jun 30, 2024
src/map/MapRouteCoordinates.js
Outdated
| 'line-width': 2, | ||
| }, | ||
| }); | ||
| if (name) { |
There was a problem hiding this comment.
For this one the name is always provided, so we can probably make it mandatory.
tananaev
reviewed
Jun 30, 2024
| @@ -1,28 +1,13 @@ | |||
| import { useTheme } from '@mui/styles'; | |||
| import { useId, useEffect } from 'react'; | |||
| import { useSelector } from 'react-redux'; | |||
| import { map } from './core/MapView'; | |||
There was a problem hiding this comment.
Can you please check the warnings and errors.
There was a problem hiding this comment.
I don't have any warnings
tananaev
reviewed
Jul 1, 2024
src/map/MapRoutePath.js
Outdated
| const id = useId(); | ||
|
|
||
| const theme = useTheme(); | ||
|
|
||
| const reportColor = useSelector((state) => { |
There was a problem hiding this comment.
the color is based on the position speed
There was a problem hiding this comment.
Yeah, but it means you're ignoring the settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… positions)
include name property in both cases.