Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataSerialize conversion for elements of the same type #1832

Merged
merged 3 commits into from
May 28, 2024

Conversation

laggui
Copy link
Member

@laggui laggui commented May 28, 2024

Checklist

  • Confirmed that run-checks all script has been executed.

Related Issues/PRs

Improve record loading speed for llama-burn

Changes

  • Check origin and destination element type and skip conversion for same type element
  • Reverted version to 0.14.0 (erroneously bumped twice since last release)

@laggui laggui force-pushed the fix/data-serialize/convert branch from 27c03a4 to 9da9878 Compare May 28, 2024 19:49
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.44%. Comparing base (e61b026) to head (9da9878).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1832   +/-   ##
=======================================
  Coverage   86.43%   86.44%           
=======================================
  Files         753      753           
  Lines       87602    87608    +6     
=======================================
+ Hits        75723    75729    +6     
  Misses      11879    11879           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanielsimard nathanielsimard merged commit e483624 into main May 28, 2024
15 checks passed
@nathanielsimard nathanielsimard deleted the fix/data-serialize/convert branch May 28, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants