Evenly distribute complete chunks/batches across partial dataset splits #3476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo run-checks
command has been executed.Related Issues/PRs
#2373
#3448
The current implementation prioritizes the number of workers, so the dataset is first split into
num_workers
partial subsets. Then each partial dataset is used to retrieve a batch. This can yield additional partial batches and doesn't match most users' expected behavior.Changes
PartialDataset::split_chunks
which evenly distributes complete chunks/batches across multiple partial datasets.split_chunks
whenBatchStrategy
defines the expected batch size (default with fixed batch size)Testing
Added unit tests