Fix autodiff cleanup #3592
Draft
Fix autodiff cleanup #3592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielsimard
requested changes
Aug 23, 2025
| // TODO: contexts cleanup | ||
|
|
||
| #[derive(Default)] | ||
| pub struct AutodiffServer { |
There was a problem hiding this comment.
We could move the context to another file context.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] Currently retains intermediate graph due to ref count, need to adjust state
Checklist
cargo run-checkscommand has been executed.Related Issues/PRs
Fixes #3513
Nodes were marked as unavailable (parent nodes unavailable) and getting cleaned up but were still referenced in another thread for (incomplete) backward pass.
Changes
Check if node is still referenced by another thread (global autodiff, multi-device setup) when marking for deletion
Testing
Tested code in linked issue, validated that such nodes are eventually cleaned up as unused roots (only server reference remains, no more parents).