CubeCL: Fix wgpu extensions possibly being emitted multiple times with the same name #3606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (63.59%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3606 +/- ##
==========================================
- Coverage 63.60% 63.59% -0.01%
==========================================
Files 1032 1032
Lines 120136 120136
==========================================
- Hits 76414 76404 -10
- Misses 43722 43732 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
laggui
reviewed
Aug 25, 2025
Comment on lines
+158
to
+160
| cubecl = { git = "https://github.com/amfaber/cubecl", default-features = false, rev = "e790a93af640c107430bf3d184ee3b631d0f57cb" } | ||
| cubecl-common = { git = "https://github.com/amfaber/cubecl", default-features = false, rev = "e790a93af640c107430bf3d184ee3b631d0f57cb" } | ||
| cubecl-quant = { git = "https://github.com/amfaber/cubecl", default-features = false, rev = "e790a93af640c107430bf3d184ee3b631d0f57cb" } |
There was a problem hiding this comment.
TODO: update to cubecl merged rev once linked PR lands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure wgpu extensions are emitted with different names
Should solve #3461, though I didn't get the concrete example to run as I didn't want to bother with installing SDL2 on windows to run gym-rs. I experienced the same panic in my model, and my model is fixed by this change.
As per the guidelines for contributing to cubecl, I am also opening a PR here to ensure nothing in burn breaks as a result of the changes.
The cubecl PR has more details