Implement QR decomposition #4250
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
cargo run-checkscommand has been executed.Related Issues/PRs
#1538
Changes
Would be nice to have more linalg operations out-of-the-box in burn. This adds a householder QR decomposition.
Also replaced the Gram-Shmidt method with a call to this one in
initializermodule.Testing
Generated examples in python and decomposed them via
numpy.linalg.qr. Then compared burn implementation against the expected output from numpy (up to a degree-of-freedom in sign). Also check that ourQis indeed orthogonal.Notes