Skip to content

Make ElementComparison optional for dtypes #4255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skewballfox wants to merge 7 commits into
base: main
Choose a base branch
from
+1,774 −1,684

added TchFloatElement and TchIntElementTraits

1e08156
Select commit
Loading
Failed to load commit list.
Open

Make ElementComparison optional for dtypes #4255

added TchFloatElement and TchIntElementTraits
1e08156
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 2, 2026 in 1s

69.01% (target 80.00%)

View this Pull Request on Codecov

69.01% (target 80.00%)

Details

Codecov Report

❌ Patch coverage is 73.02452% with 99 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.01%. Comparing base (439a26c) to head (1e08156).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/burn-tch/src/ops/int_tensor.rs 0.00% 46 Missing ⚠️
crates/burn-tch/src/ops/tensor.rs 0.00% 20 Missing ⚠️
crates/burn-backend/src/tensor/ops/int.rs 65.95% 16 Missing ⚠️
crates/burn-backend/src/tensor/ops/float.rs 90.78% 7 Missing ⚠️
crates/burn-backend/src/data/compare.rs 33.33% 4 Missing ⚠️
crates/burn-tch/src/ops/bool_tensor.rs 0.00% 3 Missing ⚠️
crates/burn-tch/src/ops/module.rs 0.00% 3 Missing ⚠️

❌ Your project check has failed because the head coverage (69.01%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4255      +/-   ##
==========================================
- Coverage   69.03%   69.01%   -0.03%     
==========================================
  Files        1409     1410       +1     
  Lines      165880   165941      +61     
==========================================
+ Hits       114520   114524       +4     
- Misses      51360    51417      +57

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov