Skip to content

fix(cubecl): tile-kernels matmul races every routine in one round - #6207

Draft
louisfd wants to merge 4 commits into
mainfrom
fix/tile-kernels-matmul-autotune
Draft

louisfd wants to merge 4 commits into
mainfrom
fix/tile-kernels-matmul-autotune

Conversation

@louisfd

@louisfd louisfd commented Oct 23, 2026

Copy link
Copy Markdown
Member

Checklist

  • I have reviewed and understand the changes in this PR.
  • Confirmed that cargo run-checks has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Needs tracel-ai/cubek#944 (i32 operands, an output of another element) and tracel-ai/cubecl#1920 (an integer sum of products compiled to nothing). This branch pins both branches' heads; it is repinned to their mains once they merge.

Changes

With tile-kernels-only, burn's matmul autotune is built on cubek's Autotune: every tile-DSL routine's settings in one ordered group, all raced in one round, and the unit-registers routine's lead under them as the floor. The list used a plain cutoff group before, so a candidate alone at the top priority level was picked without being measured, then declined the real problem (a column rhs, a batched rhs, too many rows) with nothing under it.

With the feature off, nothing changes but the pins.

Testing

On an M2 Pro, Metal, rustc 1.98.1, feature on:

  • tensor int and float matmul and fusion matmul: 39 pass (the 12 int matmul tests failed before: refused, or written as zeros).
  • clippy on burn-cubecl and burn-backend-tests, tests and benches: clean.

Not run: cargo run-checks, CUDA.

AI Usage

Written by Claude Code (an agent), under the direction of louisfd: the code and this description.

@codecov

codecov Bot commented Oct 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.39%. Comparing base (3da5d2a) to head (27fa8cc).

❌ Your project check has failed because the head coverage (66.39%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6207      +/-   ##
==========================================
+ Coverage   66.17%   66.39%   +0.21%     
==========================================
  Files         878      870       -8     
  Lines      127748   127328     -420     
==========================================
  Hits        84541    84541              
+ Misses      43207    42787     -420     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant