Repository navigation
fix(instrument): a component part of whose work fused elsewhere is not scored - #6222
Open
nathanielsimard wants to merge 2 commits into
Open
nathanielsimard wants to merge 2 commits into
nathanielsimard wants to merge 2 commits into
Conversation
…t scored A stack whose first layer's projection ran alone and whose others fused with the residual add is one component holding one launch, its floor pricing every entry: the report scored that floor against one launch's time and printed figures like 1500% of peak. FusedElsewhere now says how much of a component's work ran elsewhere, all or part; a partly fused component keeps its floor on the ladder but has no score. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6222 +/- ##
==========================================
- Coverage 66.17% 66.16% -0.02%
==========================================
Files 878 878
Lines 127748 127751 +3
==========================================
- Hits 84541 84528 -13
- Misses 43207 43223 +16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
cargo run-checkshas been executed.changelog policy in CONTRIBUTING.md.
Related Issues/PRs
None.
Changes
The report printed impossible percentages for a component that was partly fused. On a Qwen3 4B decode under fusion:
One layer's
out projran alone, and the other 35 fused with the residual add into a kernel on the parent. Since the component held a kernel of its own, it was not "fused elsewhere" and was scored: its floor covers all 36 entries (0.9 ms), while its time was one launch (0.06 ms). Its parentattentionandfeed forward(whosedownfused into the block's kernel) had the same problem, with smaller numbers.burn-instrument:FusedElsewherenow says how much of a component's work ran in a fused kernel recorded elsewhere, as a newFusedShare::{All, Part}.share()replacescontains().Allis the old set;Partis a component named by such a kernel that also ran kernels of its own.burn-instrument-report:Partcomponent keeps its floor, which the ladder counts in place of the fused kernel, exactly as before. Its row shows its measured time and its floor; the achieved column readspartly fused ↓in place of a percentage, and there is no gain. It is left out of "worth reading first". The legend explains the mark when a row shows it.The ladder's totals ("how much is on the table") don't change: they already counted a partly fused component at its floor and left the fused kernel's time out.
Testing
cargo test -p burn-instrument -p burn-instrument-report: passes.a_component_part_of_whose_work_fused_elsewhere_is_not_scoredreproduces the stack shape above; it fails without the fix.a_component_fused_elsewhere_ran_no_kernel_of_its_ownnow also asserts thePartcase.cargo clippy -p burn-instrument -p burn-instrument-report --all-targets -- -D warningsandcargo fmt: clean.cargo run-checks, and a report regenerated from a real run (no saved measurement of the run above).AI Usage
Claude Code wrote the change and its tests, ran the checks above, and wrote this description and created the PR.
🤖 Generated with Claude Code