Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (66.15%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6224 +/- ##
==========================================
- Coverage 66.16% 66.15% -0.02%
==========================================
Files 878 878
Lines 127748 127748
==========================================
- Hits 84528 84513 -15
- Misses 43220 43235 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
cargo run-checkshas been executed.changelog policy in CONTRIBUTING.md.
Related Issues/PRs
Closes #6223.
Changes
Use U8 confusion codes when supported, with the original integer expression as the fallback.
Keep count reductions and metric behavior unchanged. Add regression tests and a changelog entry.
The four codes need only two bits. U8 works with existing tensor operations; packing four codes
per byte would require separate encoding/counting logic and performance measurements.
Benchmarks
Complete Precision updates, threshold 0.5, micro reduction. Flex CPU, Intel i5-12400F,
release mode, Rust 1.98.0, default I32, one worker. Medians of nine paired rounds
(fifteen for 262,144 classes):
At
256 × 4,096, additional allocation peak falls from 9 MiB to 6 MiB. At1 × 262,144,macro gains are only 1.02–1.11× across the three metrics; top-k performance is largely unchanged.
Testing
cargo test -p burn-train --lib metric:: --no-default-features --locked: 281 passed.cargo run-checks: passed with Flex; existing ignored tests remained skipped.ran separately from latency measurements.
AI Usage
Codex autonomously implemented and tested the change, ran validation and benchmarks, and updated
the changelog following user instructions. It drafted the issue and PR descriptions and created
the issue and this PR.