Made compatible with no_std and no atomic ptr #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BjornTheProgrammer FYI, it's sufficient to fix make this work with crates in this test: https://github.com/tracel-ai/burn/tree/main/crates/burn-no-std-tests cubecl doesn't need to be no-std compatible. |
|
You're totally right, for whatever reason, during my testing on my local machine it broke without my version. I think I've found the issue though. Sorry for the inconvenience |
2 tasks
|
@nathanielsimard can you please look into this? For some reason burn-common has dependency on cube. |
Is it fine for this to be merged then? |
nathanielsimard
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for Burn's pull request #2096.
Some tests should be added to ensure that this doesn't end up breaking in the future, I can do so, but I'm unfamiliar with the testing story here. It would just need to be built with the
thumbv6m-none-eabitarget