Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ResNet implementation with pre-trained weights #13

Merged
merged 9 commits into from
Feb 10, 2024
Merged

Conversation

laggui
Copy link
Member

@laggui laggui commented Jan 18, 2024

Issue #11

This PR adds a Burn implementation for the ResNet family of computer vision models. Implementation and weights are based on torchvision.

TO-DO

  • ResNet implementation for resnet-{18, 34, 50, 101, 152}
  • Inference example
  • Use PyTorchFileRecorder to import weights
  • Switch to next Burn release version
    • The Cargo.toml file currently points to a local workspace copy of Burn since parsing the resnet weights with_key_remap requires a fix that came in after the 0.12.1 release and a fix on Candle's side to handle module parameters with pickle
  • Automatic download of pre-trained weights (need to re-export download_file_as_bytes for common use in burn)

@laggui laggui linked an issue Jan 18, 2024 that may be closed by this pull request
@laggui laggui marked this pull request as ready for review February 8, 2024 14:41
resnet-burn/Cargo.toml Outdated Show resolved Hide resolved
resnet-burn/Cargo.toml Outdated Show resolved Hide resolved
@laggui
Copy link
Member Author

laggui commented Feb 8, 2024

Addressed the changes for the current version.

Would be great to have a version that includes the fixes but that also depends on Candle releasing a new version with the module parameters fix for pickle.

Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanielsimard nathanielsimard merged commit 14eecd2 into main Feb 10, 2024
2 checks passed
@nathanielsimard nathanielsimard deleted the resnet branch February 10, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ResNet implementation
2 participants